Re: Basic DOMAIN Support - Mailing list pgsql-patches

From Tom Lane
Subject Re: Basic DOMAIN Support
Date
Msg-id 26445.1015556211@sss.pgh.pa.us
Whole thread Raw
In response to Re: Basic DOMAIN Support  ("Rod Taylor" <rbt@zort.ca>)
List pgsql-patches
"Rod Taylor" <rbt@zort.ca> writes:
>> copyfuncs.c:2232: warning: `_copyCreateDomainStmt' defined but not
> used

> Commented out, but left in for potential use.

Wrong answer --- what this is reminding you is that you forgot to call
it.

Also, I'm fairly confused by the code in MergeDomainAttributes and
DefineDomain.  You seem to have modeled this on table creation, not
type creation, which makes little or no sense to me.  Where in the
heck does a domain "inherit" from?

            regards, tom lane

pgsql-patches by date:

Previous
From: "Christopher Kings-Lynne"
Date:
Subject: Re: Basic DOMAIN Support
Next
From: Tom Lane
Date:
Subject: Re: Basic DOMAIN Support