Re: Broken handling of lwlocknames.h - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Broken handling of lwlocknames.h
Date
Msg-id 26357.1467400438@sss.pgh.pa.us
Whole thread Raw
In response to Re: Broken handling of lwlocknames.h  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Broken handling of lwlocknames.h  (Michael Paquier <michael.paquier@gmail.com>)
Re: Broken handling of lwlocknames.h  (Christoph Berg <myon@debian.org>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> Yes that would be indeed cleaner this way. I have poked a bit at that
> and finished with the attached that defines some rules to generate all
> the files needed.

I made some mostly-cosmetic changes to this and pushed it.  One thing
to note is that it seemed to me you'd broken the rule for schemapg.h:
by removing the phony target, I think you removed the behavior that
we'd always go and recheck schemapg.h's dependencies.  To do it correctly
without that target, we'd need src/backend/Makefile to know all of those
dependencies, duplicating the rather long list in catalog/Makefile.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Bug in batch tuplesort memory CLUSTER case (9.6 only)
Next
From: Robert Haas
Date:
Subject: Re: Reviewing freeze map code