Re: src/tools/msvc usage instructions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: src/tools/msvc usage instructions
Date
Msg-id 26281.1159890672@sss.pgh.pa.us
Whole thread Raw
In response to Re: src/tools/msvc usage instructions  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: src/tools/msvc usage instructions  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-hackers
"Magnus Hagander" <mha@sollentuna.net> writes:
>> which looks like they figured out that they needed to check 
>> for MicroSoft C explicitly.  I have no idea why they do not 
>> define __STDC__ however.

> Can we just define __STDC__ when compiling that file (or rather, when
> compiling any bison-generated output file)? Or is that likely to cause
> *other* issues?

That seems pretty risky.  Better to use the /Za switch or whatever it
was to get the compiler to assert it for itself.  We have precedent for
adding yes-we'd-like-a-standard-compiler-please switches where
necessary, for instance adding -Ae to CFLAGS for HP's compiler.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: src/backend/parser/parse_expr.c:exprTypmod() question
Next
From: Andrew Dunstan
Date:
Subject: Re: timestamptz alias