Re: PATCH: pgbench / int64 instead of int for xact count - Mailing list pgsql-hackers

From Tom Lane
Subject Re: PATCH: pgbench / int64 instead of int for xact count
Date
Msg-id 25618.1401050198@sss.pgh.pa.us
Whole thread Raw
In response to Re: PATCH: pgbench / int64 instead of int for xact count  (Tomas Vondra <tv@fuzzy.cz>)
List pgsql-hackers
Tomas Vondra <tv@fuzzy.cz> writes:
> Should we change the type of nxacts to int64 (thus allowing '-t' with
> 64-bit integers), or just the overflow in the printf call? I don't find
> it very practical to use -t with values not fitting into 32-bits (the -T
> seems better to do that), so I'm inclined to just fix the printf.

I concur: I don't see people setting -t higher than INT_MAX, but a -t
times -c product exceeding INT_MAX seems more plausible.

> Patch v3 attached.

Looks good, pushed.
        regards, tom lane



pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: IMPORT FOREIGN SCHEMA statement
Next
From: Tom Lane
Date:
Subject: Re: Sending out a request for more buildfarm animals?