Re: _isnan() on Windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: _isnan() on Windows
Date
Msg-id 25422.1531254222@sss.pgh.pa.us
Whole thread Raw
In response to Re: _isnan() on Windows  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: _isnan() on Windows
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2018-Jul-10, Tom Lane wrote:
>> I disagree --- including <float.h> in c.h, as this would have us do,
>> seems like a huge expansion of the visibility of that header.  Moreover,
>> doing that only on Windows seems certain to lead to missing-header
>> problems in the reverse direction, ie patches developed on Windows
>> will fail elsewhere.

> I don't think so, because that's only done for MSVC older than 2013.
> Nobody uses that for new development anymore.

Hm.  OK, maybe it's all right given that.  I'm still a bit worried
about downsides, but no doubt the buildfarm will tell us.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Jerry Jelinek
Date:
Subject: Re: patch to allow disable of WAL recycling
Next
From: "Joshua D. Drake"
Date:
Subject: Re: patch to allow disable of WAL recycling