On 2018-Jul-10, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Oh, it looks like commits 33a7101281c6, 8e211f539146, 86dbbf20d849
> > (probably others) papered over this by the expedient of adding #include
> > <float.h> to random .c files rather than your patch, which seems the
> > proper fix.
>
> I disagree --- including <float.h> in c.h, as this would have us do,
> seems like a huge expansion of the visibility of that header. Moreover,
> doing that only on Windows seems certain to lead to missing-header
> problems in the reverse direction, ie patches developed on Windows
> will fail elsewhere.
I don't think so, because that's only done for MSVC older than 2013.
Nobody uses that for new development anymore. Downloading versions
prior to 2017 is difficult enough already.
> I think we should stick with the existing coding convention of including
> that only in the specific .c files that need it.
It seems saner to contain the ugliness to a port-specific file, where it
won't pollute two dozen files for no reason.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
