Request a Demo
Home   >   mailing lists

Re: [Patch] timezone/zic.c: Fix file handle leak in dolink() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()
Date
Msg-id 2510832.1766941165@sss.pgh.pa.us
Whole thread Raw
In response to Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()  ("zengman" <zengman@halodbtech.com>)
List pgsql-hackers
Tree view 
"=?ISO-8859-1?B?emVuZ21hbg==?=" <zengman@halodbtech.com> writes:
> Furthermore, I noticed that some of the test code in `contrib/pg_trgm/trgm_regexp.c` does not check the return value
ofthe `fopen()` call.  
> I'm not sure if it's necessary to make the modification.

Probably not worth the trouble.  This is barely even debug-grade
code, seeing that there's no provision to change the target file
name.  It's clearly not meant for use in unfriendly environments.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()
Next
From: Tom Lane
Date:
Subject: Re: Get rid of "Section.N.N.N" on DOCs