Re: [Patch] timezone/zic.c: Fix file handle leak in dolink() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()
Date
Msg-id 2510355.1766940963@sss.pgh.pa.us
Whole thread Raw
In response to [Patch] timezone/zic.c: Fix file handle leak in dolink()  ("zengman" <zengman@halodbtech.com>)
List pgsql-hackers
"=?gb18030?B?emVuZ21hbg==?=" <zengman@halodbtech.com> writes:
> I noticed a small issue and made a tiny patch to fix it ¡ª it addresses a file handle leak in the dolink() function
ofsrc/timezone/zic.c.  

Huh?  The program is going to exit() two lines further down.
What's the point of closing here?

Even if there were a plausible argument for issuing close(),
I wouldn't care to diverge from upstream zic.  If you like
you can go try to persuade the tzdb crew that this is a
useful change.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: Optimize LISTEN/NOTIFY
Next
From: Tom Lane
Date:
Subject: Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()