Re: [COMMITTERS] pgsql: We no longer need to palloc the VacuumStmt node; keeping it on - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: We no longer need to palloc the VacuumStmt node; keeping it on
Date
Msg-id 25086.1174684942@sss.pgh.pa.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: We no longer need to palloc the VacuumStmt node; keeping it on  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
alvherre@postgresql.org (Alvaro Herrera) writes:
> We no longer need to palloc the VacuumStmt node; keeping it on the stack is
> simpler.

If you're going to do that, you should at least set the nodeTag so that
the struct appears valid to onlookers.  A memset wouldn't be out of
place either to make sure that any uninitialized fields behave sanely.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Matthew T. O'Connor"
Date:
Subject: Re: Documentation access problems.
Next
From: Tom Lane
Date:
Subject: Re: EXISTS optimization