Re: [COMMITTERS] pgsql: We no longer need to palloc the VacuumStmt node; keeping it on - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [COMMITTERS] pgsql: We no longer need to palloc the VacuumStmt node; keeping it on
Date
Msg-id 20070323215740.GE4507@alvh.no-ip.org
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: We no longer need to palloc the VacuumStmt node; keeping it on  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> alvherre@postgresql.org (Alvaro Herrera) writes:
> > We no longer need to palloc the VacuumStmt node; keeping it on the stack is
> > simpler.
> 
> If you're going to do that, you should at least set the nodeTag so that
> the struct appears valid to onlookers.  A memset wouldn't be out of
> place either to make sure that any uninitialized fields behave sanely.

Done, thanks.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: EXISTS optimization
Next
From: "Kevin Grittner"
Date:
Subject: Re: EXISTS optimization