Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()
Date
Msg-id 25027.1321650862@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()
List pgsql-hackers
Tree view 
Andres Freund <andres@anarazel.de> writes:
> For unknown reasons the function used non chained ifs for every handled
> nodeType.
> Replacing the if chain with if; else if; ... resulted in a small
> speedup. Replacing it with a switch() in a bigger one.

Cool, but this patch is impossible to validate by eye.  Could you
resubmit a version that doesn't reindent unchanged code?  Leave it
for pgindent to clean that up later.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: EXPLAIN (plan off, rewrite off) for benchmarking
Next
From: Peter Geoghegan
Date:
Subject: Re: Inlining comparators as a performance optimisation