Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch() - Mailing list pgsql-hackers

On Friday, November 18, 2011 10:14:22 PM Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > For unknown reasons the function used non chained ifs for every handled
> > nodeType.
> > Replacing the if chain with if; else if; ... resulted in a small
> > speedup. Replacing it with a switch() in a bigger one.
> 
> Cool, but this patch is impossible to validate by eye.  Could you
> resubmit a version that doesn't reindent unchanged code?  Leave it
> for pgindent to clean that up later.
Sure. It was just to confusing reading the code without reindenting.

Btw, I found git diff/show/blame -w very useful to view reindent code.

Actually git show -w seems to produce an applyable patch which doesn't 
reindent...

Andres