Re: [HACKERS][PATCH] adding simple sock check for windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS][PATCH] adding simple sock check for windows
Date
Msg-id 24146.1522560607@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS][PATCH] adding simple sock check for windows  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Amit Kapila <amit.kapila16@gmail.com> writes:
> oops, I just saw that you have already pushed a fix for it.  I am not
> sure if we should try to do anything about walrcv_receive's output
> still uses pgsocket instead of int as the usage in itself doesn't have
> any problem.

I see a few places where we're still assigning PQsocket's result to a
pgsocket variable, but none of them are worrying about the possibility
that it's not a valid socket, and I'm not sure they need to.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: lazy detoasting
Next
From: David Rowley
Date:
Subject: Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath