Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Зотов Роман's message of lun abr 11 17:39:32 -0300 2011:
> I had a brief look at this patch, updating it to current HEAD past some
> pgindent conflicts. It seems sane, but as Zotov says, it doesn't do
> anything yet: it only changes typispreferred from bool to int. I'm
> attaching it for the benefit of those interested.
> The interesting discussion is what happens next. To me, this is all
> related to this previous discussion:
> http://archives.postgresql.org/pgsql-hackers/2010-09/msg00232.php
Yeah, there doesn't seem like much point unless we have a clear idea
what we're going to do with the change. In particular, I'm quite
unimpressed with the (undocumented) changes in func_select_candidate;
there's no justification given for making it work like this, and frankly
I see no reason to assume that this behavior will be useful.
I would also note that this patch is seriously incomplete, in that it
fails to touch the behavior of CREATE TYPE, which presumably ought to
now take something other than a boolean (but with backwards compatibility
handled in some reasonable fashion). Documentation changes seem lacking
as well. But there's not good reason to spend time cleaning up those
issues unless we're convinced this is a good way to proceed forward,
and so far I'm not convinced.
regards, tom lane
