Postgres Pro
Downloads
Home   >   mailing lists

Re: Hot Standy introduced problem with query cancel behavior - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Hot Standy introduced problem with query cancel behavior
Date
Msg-id 23470.1262877782@sss.pgh.pa.us
Whole thread Raw
In response to Re: Hot Standy introduced problem with query cancel behavior  (Joachim Wieland <joe@mcknight.de>)
Responses Re: Hot Standy introduced problem with query cancel behavior
List pgsql-hackers
Tree view 
Joachim Wieland <joe@mcknight.de> writes:
> As there were so many boolean SomethingCancelPending variables I changed them
> to be bitmasks and merged all of them into a single variable.

This seems like a truly horrid idea, because those variables are set by
signal handlers.  A bitmask cannot be manipulated atomically, so you
have almost certainly introduced race-condition bugs.
        regards, tom lane

pgsql-hackers by date:

Previous
From: "Greg Sabino Mullane"
Date:
Subject: Re: Testing with concurrent sessions
Next
From: Robert Haas
Date:
Subject: Re: Buffer statistics for pg_stat_statements