Postgres Pro
Downloads
Home   >   mailing lists

Re: strange error reporting - Mailing list pgsql-hackers

From Tom Lane
Subject Re: strange error reporting
Date
Msg-id 2338295.1611697523@sss.pgh.pa.us
Whole thread Raw
In response to Re: strange error reporting  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: strange error reporting  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> pgbench has one occurrence of the old pattern in master, in line 6043.
> However, since doConnect() returns NULL when it gets CONNECTION_BAD,
> that seems dead code.  This patch kills it.

Oh ... I missed that because it wasn't adjacent to the PQconnectdbParams
call :-(.  You're right, that's dead code and we should just delete it.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: 13dev failed assert: comparetup_index_btree(): ItemPointer values should never be equal
Next
From: Justin Pryzby
Date:
Subject: wiki:PostgreSQL_14_Open_Items