Re: logical replication of truncate command with trigger causes Assert - Mailing list pgsql-hackers

From Tom Lane
Subject Re: logical replication of truncate command with trigger causes Assert
Date
Msg-id 2321999.1623517262@sss.pgh.pa.us
Whole thread Raw
In response to Re: logical replication of truncate command with trigger causes Assert  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: logical replication of truncate command with trigger causes Assert
List pgsql-hackers
Amit Kapila <amit.kapila16@gmail.com> writes:
> On Fri, Jun 11, 2021 at 8:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I was thinking maybe we could mark all these replication protocol
>> violation errors non-translatable.  While we don't want to crash on a
>> protocol violation, it shouldn't really be a user-facing case either.

> I don't see any problem with that as these are not directly related to
> any user operation. So, +1 for making these non-translatable.

Done that way.  On re-reading the code, there were a bunch more
Asserts that could be triggered by bad input data, so the committed
patch has rather more corrections than I posted before.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: [PATCH] check_random_seed: use a boolean not an int..
Next
From: Tom Lane
Date:
Subject: Re: Race condition in recovery?