Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib
Date
Msg-id 22912.1273686247@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> momjian@postgresql.org (Bruce Momjian) writes:
>>> Add PGAPPICON to all executable makefiles.
>> 
>> Is it really a good idea to have done that to the server, in particular?
>> I can't imagine it being a good idea to launch the postmaster from a
>> GUI, which is what I suppose this is good for.

> Well, I assume this was the "icon", which I assumed should match for all
> the binaries, as compared to config files, for example.

Er... why are you committing undiscussed patches if you just "assume"
they will work, or indeed do anything useful at all?  You should not
have touched this if you don't know exactly what it will do and why
changing it is a good thing.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib
Next
From: "Joshua D. Drake"
Date:
Subject: Re: primary/secondary/master/slave/standby