Re: [PATCHES] snprintf() argument reordering not working - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] snprintf() argument reordering not working
Date
Msg-id 2287.1133815039@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] snprintf() argument reordering not working  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [PATCHES] snprintf() argument reordering not working  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> Andrew Dunstan <andrew@dunslane.net> writes:
>>> The problem is that the alias will be picked up by every libpq client.
>> 
>> Not at all; libpq clients do not import c.h.

> Well, all the programs that use postgres-fe.h do.

Sure, but all of them do (or should) include libpgport and can get at
the functions from that.

> I'm coming around to thinking that the simple solution is just to use it 
> unconditionally on Windows.

I agree that that's what we should do, but it should be done the same
way we handle other routines from libpgport.  None of those are exported
to our client-side programs via libpq.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Shared locking in slru.c
Next
From: Bruce Momjian
Date:
Subject: *printf and zero size