Re: Add explicit casts in four places to simplehash.h - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add explicit casts in four places to simplehash.h
Date
Msg-id 2280953.1667568342@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add explicit casts in four places to simplehash.h  (David Geier <geidav.pg@gmail.com>)
List pgsql-hackers
David Geier <geidav.pg@gmail.com> writes:
> On 11/3/22 15:50, Tom Lane wrote:
>> The bigger picture here is that we do actually endeavor to keep
>> (most of) our headers C++ clean, but our tool cpluspluscheck misses
>> these problems because it doesn't try to use these macros.
>> I wonder whether there is a way to do better.

> What about having a custom header alongside cpluspluscheck which 
> references all macros we care about?

Can't see that that would help, because of the hand maintenance
required to make it useful.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Reid Thompson
Date:
Subject: Re: Add tracking of backend memory allocated to pg_stat_activity
Next
From: "Imseih (AWS), Sami"
Date:
Subject: Re: Add index scan progress to pg_stat_progress_vacuum