Re: Add explicit casts in four places to simplehash.h - Mailing list pgsql-hackers

From David Geier
Subject Re: Add explicit casts in four places to simplehash.h
Date
Msg-id 0f0d2561-1190-1f45-0c5f-ed42f2c80aaf@gmail.com
Whole thread Raw
In response to Re: Add explicit casts in four places to simplehash.h  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add explicit casts in four places to simplehash.h
List pgsql-hackers
On 11/3/22 15:50, Tom Lane wrote:
> Seems reasonable, so done (I fixed one additional spot you missed).
Thanks!
> The bigger picture here is that we do actually endeavor to keep
> (most of) our headers C++ clean, but our tool cpluspluscheck misses
> these problems because it doesn't try to use these macros.
> I wonder whether there is a way to do better.

What about having a custom header alongside cpluspluscheck which 
references all macros we care about?
We could start with the really big macros like the ones from 
simplehash.h and add as we go.
I could give this a try if deemed useful.

--
David Geier
(ServiceNow)




pgsql-hackers by date:

Previous
From: sirisha chamarthi
Date:
Subject: Reviving lost replication slots
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)