Re: [PATCH] fix for C4141 warning on MSVC - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] fix for C4141 warning on MSVC
Date
Msg-id 22599.1516754545@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] fix for C4141 warning on MSVC  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [PATCH] fix for C4141 warning on MSVC
List pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Wed, Jan 24, 2018 at 1:16 PM, Michail Nikolaev
> <michail.nikolaev@gmail.com> wrote:
>> Just very small fix for C4141 warning

> Thanks.  This is similar to the fix I proposed over here:
> https://www.postgresql.org/message-id/CAEepm%3D2iTKvbebiK3CdoczQk4_FfDt1EeU4c%2BnGE340JH7gQ0g%40mail.gmail.com

> Perhaps we should combine these?

+1.  The previous thread seems to have died off with nothing happening,
but we still have those issues to resolve.  I like the idea of making
the macro be a direct drop-in substitute for "inline" rather than
something you use in addition to "inline".  And if we do that, it
definitely should expand to plain "inline" if we have no other idea.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Missing wal_receiver_status_interval in Subscribers section
Next
From: Bruce Momjian
Date:
Subject: Re: documentation is now XML