Alvaro Herrera <alvherre@commandprompt.com> writes:
> ... but I don't really see that this buys much of anything. I think a
> better answer to this kind of problem would be
> + Assert(IsA(def, ReloptElem));
Well, that will help to make wrong-node-type mistakes more obvious (at
least if you're running an assert-enabled build). It does nothing to
*fix* the mistakes. And it does nothing to eliminate duplicate coding
for essentially redundant node types, which is bothering me as well.
I don't like any of the changes I see in define.c since 8.3 ...
regards, tom lane
