Re: pgbench tests vs Windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgbench tests vs Windows
Date
Msg-id 2223.1563923631@sss.pgh.pa.us
Whole thread Raw
In response to pgbench tests vs Windows  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: pgbench tests vs Windows
List pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> In commit ed8a7c6fcf9 we added some extra tests to pgbench, including
> this snippet:
>     \setshell two\
>       expr \
>         1 + :one
> Unfortunately, this isn't portable, as I've just discovered at the cost
> of quite a bit of time. In particular, you can't assume expr is present
> and in the path on Windows.

Ugh.

> The Windows equivalent would be something like:
>     \setshell two\
>       @set /a c = 1 + :one  && echo %c%

I wonder how universal that is, either.

> I propose to prepare a patch along these lines. Alternatively we could
> just drop it - I don't think the test matters all that hugely.

I'd say try that, but if it doesn't work right away, just skip the
test on Windows.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: stress test for parallel workers
Next
From: Tom Lane
Date:
Subject: Re: stress test for parallel workers