Re: text coverage for EXTRACT() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: text coverage for EXTRACT()
Date
Msg-id 2208368.1591711912@sss.pgh.pa.us
Whole thread Raw
In response to Re: text coverage for EXTRACT()  (Vik Fearing <vik@postgresfriends.org>)
Responses Re: text coverage for EXTRACT()  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Vik Fearing <vik@postgresfriends.org> writes:
> On 6/9/20 1:36 PM, Peter Eisentraut wrote:
>> During the discussion in [0] I noticed that the extract()/date_part()
>> variants for time, timetz, and interval had virtually no test coverage.
>> So I put some more tests together, which should be useful if we decide
>> to make any changes in this area per [0].

> These look straightforward to me.

+1 here as well.

> Looking at that big table, I see everything is 0-based except the
> quarter.  That seems unfortunate, and if this were a new feature I'd
> lobby to have it changed.  I don't think we can do anything about it
> now, though.

Yeah, that ship has sailed :-(

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: pg_dump and concurrent DDL activity
Next
From: Odin Ugedal
Date:
Subject: Re: [PATCH] Add support for choosing huge page size