Re: usleep feature for pgbench - Mailing list pgsql-hackers

From Tom Lane
Subject Re: usleep feature for pgbench
Date
Msg-id 21985.1183671014@sss.pgh.pa.us
Whole thread Raw
In response to Re: usleep feature for pgbench  (Jan Wieck <JanWieck@Yahoo.com>)
Responses Re: usleep feature for pgbench  (Alvaro Herrera <alvherre@commandprompt.com>)
Re: usleep feature for pgbench  (Jan Wieck <JanWieck@Yahoo.com>)
List pgsql-hackers
Jan Wieck <JanWieck@Yahoo.com> writes:
> I think I've coded it in a way that if one doesn't use the \usleep 
> command at all, it will never even call gettimeofday() and use a NULL 
> timeout in select() as it used to.

Did you check that the observed performance for non-usleep-using scripts
didn't change?  If this extra overhead causes a reduction in reported
TPS rates it would make it hard to compare older and newer tests.

Other than that I've got no objection to it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Bgwriter strategies
Next
From: Alvaro Herrera
Date:
Subject: Re: usleep feature for pgbench