Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
Date
Msg-id 21833.1130097304@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
List pgsql-hackers
"Magnus Hagander" <mha@sollentuna.net> writes:
> Here's another version of this patch ;-) I've based it on your patch, so
> the changes to ovalue etc should sitill be there.

In the spirit of incremental improvement ... I've taken Magnus' version
and added the proposed change to re-enable Qingqing's patch by skipping
WaitForSingleObjectEx altogether in the CHECK_FOR_INTERRUPTS code path.
I also removed WaitForSingleObjectEx in pgwin32_poll_signals(), which
AFAICS should be just like CHECK_FOR_INTERRUPTS.  I think this is what
we are proposing to actually apply to 8.1beta4.  I can't test it though,
so please check it over...

            regards, tom lane


Attachment

pgsql-hackers by date:

Previous
From: Qingqing Zhou
Date:
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
Next
From: "Magnus Hagander"
Date:
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance