Re: New Object Access Type hooks - Mailing list pgsql-hackers

From Tom Lane
Subject Re: New Object Access Type hooks
Date
Msg-id 2163177.1649105224@sss.pgh.pa.us
Whole thread Raw
In response to Re: New Object Access Type hooks  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: New Object Access Type hooks  (Mark Dilger <mark.dilger@enterprisedb.com>)
List pgsql-hackers
Mark Dilger <mark.dilger@enterprisedb.com> writes:
>> On Apr 4, 2022, at 12:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> So scratch that.  Maybe we'd better add "could not send data to server"
>> to the regex?

> If it fails in pqsecure_raw_write(), you get either "server closed the connection unexpectedly" or "could not send
datato server".  Do we need to support pgtls_write() or pg_GSS_write(), which have different error messages? 

Don't see why, since this test sets up a new cluster in which neither
is enabled.

> Is it possible that pgFlush will call pqSendSome which calls pqReadData before trying to write anything, and get back
a"could not receive data from server" from pqsecure_raw_read()? 

Yeah, it's plausible to get a failure on either the write or read side
depending on timing.

Perhaps libpq should be trying harder to make those cases look alike, but
this test is about server behavior not libpq behavior, so I'm inclined
to just make it lax.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: shared-memory based stats collector - v68
Next
From: Mark Dilger
Date:
Subject: Re: New Object Access Type hooks