Re: WIP patch for consolidating misplaced-aggregate checks - Mailing list pgsql-hackers

From Tom Lane
Subject Re: WIP patch for consolidating misplaced-aggregate checks
Date
Msg-id 2157.1344960252@sss.pgh.pa.us
Whole thread Raw
In response to Re: WIP patch for consolidating misplaced-aggregate checks  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: WIP patch for consolidating misplaced-aggregate checks
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Speaking of english words, I was wondering at "check" the other day.
> For example, we have

> #: catalog/heap.c:2171
> #, c-format
> msgid "check constraint \"%s\" already exists"

> #: catalog/heap.c:2534
> #, c-format
> msgid "only table \"%s\" can be referenced in check constraint"

> And so on (there are several more).  Note that here we use "check
> constraint" without any capitalization.

FWIW, I think I changed "check" to "CHECK" in a couple of messages
recently, for exactly the reason that it seemed to be used in its
keyword meaning rather than as plain English text.  Perhaps we
should just go around and do that consistently.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Statistics and selectivity estimation for ranges
Next
From: Josh Berkus
Date:
Subject: Re: 9.2 Cascading replication after slave promotion