Re: [HACKERS] logical replication and SIGHUP - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] logical replication and SIGHUP
Date
Msg-id 21464.1491828021@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] logical replication and SIGHUP  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
Responses Re: [HACKERS] logical replication and SIGHUP  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
List pgsql-hackers
Petr Jelinek <petr.jelinek@2ndquadrant.com> writes:
> Looks good to me. Just as a note, we'll have to handle this newly
> supported config rereads in the async commit patch where we override
> synchronous_commit GUC, but the config reread will change it back.

Umm ... you're doing what?

There are mechanisms for making local changes to a GUC.  Just stomping
on the variable is not an approved way to do it.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf
Next
From: Petr Jelinek
Date:
Subject: Re: [HACKERS] logical replication and SIGHUP