Re: Test::More version - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Test::More version
Date
Msg-id 2140009.1636998219@sss.pgh.pa.us
Whole thread Raw
In response to Re: Test::More version  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Test::More version
Re: Test::More version
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> Thanks. pushed a slightly more robust version.

I think we have enough info now to draw conclusions.  There are several
buildfarm animals that are running TAP tests but haven't reported since
this went in.  However, I don't think any of them will yield surprises:

 frogfish      | 2021-11-10 02:24:27 | checking for perl module Test::More 0.87... ok
 mandrill      | 2021-11-12 04:45:42 | checking for perl module Test::More 0.87... ok
 mereswine     | 2021-11-12 09:48:49 | checking for perl module Test::More 0.87... ok
 sungazer      | 2021-11-10 20:27:12 | checking for perl module Test::More 0.87... ok
 tern          | 2021-11-09 05:27:38 | checking for perl module Test::More 0.87... ok
 topminnow     | 2021-11-08 05:03:17 | checking for perl module Test::More 0.87... ok

mereswine is running pretty up-to-date Debian, so that's not going to
be an old version.  mandrill, sungazer, and tern share the same host
as hornet, which has reported using 1.302183.  I cheated and looked at
frogfish/topminnow's host, and it has Test::More 0.98:

tgl@erpro8-fsf1:~$ perl -MTest::More -e 'print "$Test::More::VERSION\n"';
0.98

So this should be a pretty complete summary of relevant old Test::More
versions:

 prairiedog    | 2021-11-13 12:38:32 | checking for perl module Test::More 0.87... 0.8701
 lapwing       | 2021-11-13 04:40:12 | checking for perl module Test::More 0.87... 0.98
 prion         | 2021-11-13 03:53:16 | checking for perl module Test::More 0.87... 0.98
 snapper       | 2021-11-13 17:27:29 | checking for perl module Test::More 0.87... 0.98
 curculio      | 2021-11-13 05:15:54 | checking for perl module Test::More 0.87... 1.001002
 butterflyfish | 2021-11-13 06:00:29 | checking for perl module Test::More 0.87... 1.001014

There are a couple more running 1.001014, and everything else is
1.302something.

So, discounting prairiedog's intentionally trailing-edge installation,
the oldest stuff in the buildfarm is 0.98, of which there are five
instances belonging to four different owners.

Based on this, I'm inclined to think we should select 0.98 as the
minimum version.  Anything later would inconvenience some people.
OTOH, it doesn't look like there's any value in promising compatibility
with 0.96 instead, especially since I see a couple of subplan-related
bug fixes in 0.97 and 0.98 in Test::Simple's changelog.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Yugo NAGATA
Date:
Subject: Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error
Next
From: Martín Marqués
Date:
Subject: Re: Read access for pg_monitor to pg_replication_origin_status view