Re: Missing PG_INT32_MIN in numutils.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Missing PG_INT32_MIN in numutils.c
Date
Msg-id 21344.1460556690@sss.pgh.pa.us
Whole thread Raw
In response to Re: Missing PG_INT32_MIN in numutils.c  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Missing PG_INT32_MIN in numutils.c
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I am not very convinced that this is an improvement, because you took
>> what had been two hard-wired constants and replaced them with a symbol
>> and a hard-wired constant.This is more prone to break, not less so.

> I think it's kind of six of one, half a dozen of the other, but if you
> feel strongly about it, revert the patch.

I don't care enough to do that either, but I wanted to point out that
it's pretty questionable whether this is a stylistic improvement.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Next
From: José Luis Tallón
Date:
Subject: Re: Parser extensions (maybe for 10?)