Re: pgsql: Move strtoint() to common - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Move strtoint() to common
Date
Msg-id 21199.1521167826@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Move strtoint() to common  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Move strtoint() to common  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Mar 15, 2018 at 06:57:27PM -0400, Tom Lane wrote:
>> I think what's wrong is that src/tools/msvc/ecpg_regression.proj
>> needs to be taught that tests under ecpg/test/compat-oracle need
>> to be run with "-C ORACLE".  Neither that directory nor that
>> switch existed before yesterday.  There's already stuff in there
>> that knows about "-C INFORMIX", but beyond seeing the switch it
>> looks like line noise to me, so I'm not volunteering to fix it.

> I can confirm that commit 3b7ab43 is at fault, that I can see the
> failure, and that the patch attached fixes the failure.

Seems sane AFAICT, so pushed.  Thanks!

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix msvc/ecpg_regression.proj for recent ECPG test additions.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Move strtoint() to common