> Thank you for catching this! You are absolutely right. I apologize for
> using non-ASCII characters in the code comments.
>
> I've reviewed all the RPR-related files and found additional instances
> of non-ASCII characters:
> - Arrows "→" instead of "->"
> - Superscript "²" instead of "^2"
> - Greater-than-or-equal "≥" instead of ">="
>
> Found in:
> - src/backend/optimizer/plan/rpr.c (1 instance)
> - src/backend/executor/nodeWindowAgg.c (5 instances)
> - src/include/nodes/execnodes.h (4 instances)
> - src/test/regress/sql/rpr.sql (7 instances)
> - src/test/regress/sql/rpr_base.sql (15 instances)
> - src/test/regress/expected/rpr.out (7 instances)
> - src/test/regress/expected/rpr_base.out (15 instances)
>
> Total: 54 instances across 7 files.
>
> To ensure comprehensive coverage, I created a Python verification tool
> that checks for non-ASCII characters and reports their Unicode code
> points. I've verified all 46 files changed in the v42 patch series,
> and confirmed no additional non-ASCII characters remain.
>
> I'll be more careful going forward to use only ASCII characters in
> source files and comments. Updated patch attached.
Thank you for the prompt response. Your patch applied cleanly here.
BTW, I have a question regarding NFA related objects initialization in
nodeWindowAgg.c.
In release_partition():
/* Reset NFA state for new partition */
winstate->nfaContext = NULL;
winstate->nfaContextTail = NULL;
winstate->nfaContextFree = NULL;
winstate->nfaStateFree = NULL;
winstate->nfaLastProcessedRow = -1;
winstate->nfaStatesActive = 0;
winstate->nfaContextsActive = 0;
While in ExecInitWindowAgg():
/* Initialize NFA free lists for row pattern matching */
winstate->nfaContext = NULL;
winstate->nfaContextTail = NULL;
winstate->nfaContextFree = NULL;
winstate->nfaStateFree = NULL;
winstate->nfaLastProcessedRow = -1;
So the latter does not initialize winstate->nfaStatesActive and
winstate->nfaContextsActive. Can you please explain why?
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
