On 2025-Nov-07, Bertrand Drouvot wrote:
> What do you think of the attached? It contains the ones you mentioned and some
> others. The patch attached has been generated by the .cocci script [1].
>
> [1]:
https://github.com/bdrouvot/coccinelle_on_pg/blob/main/replace_literal_0_assignement_with_InvalidXLogRecPtr.cocci
Hmm, I tried to recreate your patch using this .cocci file, and in my
run, there's a few changes in your patch that my spatch run didn't
detect. I wonder if that's because my spatch version is buggy, or
because you hacked the .cocci file beyond what's in your github repo.
In case you're curious, here's two commits: what I got with my spatch
run as a first step, and then the patch you sent on top of that.
(I'm wondering if I should reproduce your previous patches in case there
were also differences there. Life is short though.)
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
