Re: Few untranslated error messages in OAuth - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Few untranslated error messages in OAuth
Date
Msg-id 0EEBCAA8-A5AC-4E3B-BABA-0BA7A08C361B@yesql.se
Whole thread Raw
In response to Re: Few untranslated error messages in OAuth  (Álvaro Herrera <alvherre@kurilemu.de>)
Responses Re: Few untranslated error messages in OAuth
List pgsql-hackers
> On 13 Nov 2025, at 13:32, Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Nov-13, Daniel Gustafsson wrote:
>
>> I was pondering that since auth error messages in backend libpq does this, but
>> since we don't use gettext_noop anywhere else in frontend libpq today it makes
>> sense to go with libpq_gettext and update the docs instead.
>>
>> Unless you, who has more translation/nls insights than me, feel strongly about
>> gettext_noop I'll go ahead with the current patch.
>
> gettext_noop() does something completely different from libpq_gettext(),
> and the more I think about this, the more I think doing libpq_gettext()
> is the wrong thing.

If so, should that be extended to oauth_json_set_error as well? (and possibly others?)

> I can give it a shot if you want.

If you have time, that would be great.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Few untranslated error messages in OAuth
Next
From: Álvaro Herrera
Date:
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro