Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date
Msg-id 20251008.085016.1771833814329805825.ishii@postgresql.org
Whole thread Raw
In response to Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
> I just noticed this compiler warning in a CI run,
> 
> [16:06:29.920] ../src/backend/executor/nodeWindowAgg.c:3820:16: warning: ‘datum’ may be used uninitialized
[-Wmaybe-uninitialized]
> [16:06:29.920]  3820 |         return datum;
> [16:06:29.920]       |                ^~~~~
> [16:06:29.920] ../src/backend/executor/nodeWindowAgg.c:3719:25: note: ‘datum’ was declared here
> [16:06:29.920]  3719 |         Datum           datum;
> [16:06:29.920]       |                         ^~~~~
> 
> The logic in this function looks somewhat wicked.

Thanks for the report. I believe the warning is eliminated in the v2
patch[1].

Best regards,

[1] https://www.postgresql.org/message-id/20251007.112832.740065769089328041.ishii%40postgresql.org
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: src/include/utils/float.h comment one link stable
Next
From: Tomas Vondra
Date:
Subject: Re: Fix overflow of nbatch