Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date
Msg-id 202510051612.gw67jlc2iqpw@alvherre.pgsql
Whole thread Raw
In response to Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
List pgsql-hackers
On 2025-Oct-03, Tatsuo Ishii wrote:

> I have just pushed the patch (plus patches for syntax.sgml and
> sql_features.txt. They were missued after I splitted the patch).
> Thank you for your effort!

I just noticed this compiler warning in a CI run,

[16:06:29.920] ../src/backend/executor/nodeWindowAgg.c:3820:16: warning: ‘datum’ may be used uninitialized
[-Wmaybe-uninitialized]
[16:06:29.920]  3820 |         return datum;
[16:06:29.920]       |                ^~~~~
[16:06:29.920] ../src/backend/executor/nodeWindowAgg.c:3719:25: note: ‘datum’ was declared here
[16:06:29.920]  3719 |         Datum           datum;
[16:06:29.920]       |                         ^~~~~

The logic in this function looks somewhat wicked.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c)
Next
From: Tom Lane
Date:
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options