Re: Log prefix missing for subscriber log messages received from publisher - Mailing list pgsql-hackers

On 2025-Jul-18, vignesh C wrote:

> diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
> index 304f3c20f83..c1ce6f33436 100644
> --- a/contrib/postgres_fdw/connection.c
> +++ b/contrib/postgres_fdw/connection.c
> @@ -625,6 +625,9 @@ connect_pg_server(ForeignServer *server, UserMapping *user)
>                              server->servername),
>                       errdetail_internal("%s", pchomp(PQerrorMessage(conn)))));
>  
> +        PQsetNoticeReceiver(conn, libpqsrv_notice_receiver,
> +                            "received message via remote connection");
> +

These need to be:

    PQsetNoticeReceiver(conn, libpqsrv_notice_receiver,
                        gettext_noop("received message via remote connection"));

so that the strings are picked up by gettext.


Also, I don't see why there are three patches here instead of just one.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/