Re: Yet another failure mode in pg_upgrade - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Yet another failure mode in pg_upgrade
Date
Msg-id 20244.1346525015@sss.pgh.pa.us
Whole thread Raw
In response to Re: Yet another failure mode in pg_upgrade  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Yet another failure mode in pg_upgrade  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Well, you only want the unix_socket* if sockdir is defined, but you want
> LISTEN_STR unconditionally, even if there is no sockdir.

Really?  What will happen when the installation's default is to not
listen on any Unix socket?  (unix_socket_directories = '' in
postgresql.conf.)

I'm inclined to think that the "no sockdir" case is broken and you
should get rid of it.  If you're starting a postmaster, you can and
should tell it a sockdir, period.  If you're running a live check this
code is all moot anyway.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Yet another failure mode in pg_upgrade
Next
From: Bruce Momjian
Date:
Subject: Re: Yet another failure mode in pg_upgrade