Re: confusing / inefficient "need_transcoding" handling in copy - Mailing list pgsql-hackers

From Sutou Kouhei
Subject Re: confusing / inefficient "need_transcoding" handling in copy
Date
Msg-id 20241206.162042.434236683509293328.kou@clear-code.com
Whole thread Raw
In response to Re: confusing / inefficient "need_transcoding" handling in copy  (Sutou Kouhei <kou@clear-code.com>)
List pgsql-hackers
Hi Michael,

ping.

(Do you think that this patch is still needed?)


Thanks,
-- 
kou

In <20240214.114608.2091541942684063981.kou@clear-code.com>
  "Re: confusing / inefficient "need_transcoding" handling in copy" on Wed, 14 Feb 2024 11:46:08 +0900 (JST),
  Sutou Kouhei <kou@clear-code.com> wrote:

> Hi,
> 
> In <ZcvlgMEjt3qY8eiL@paquier.xyz>
>   "Re: confusing / inefficient "need_transcoding" handling in copy" on Wed, 14 Feb 2024 06:56:16 +0900,
>   Michael Paquier <michael@paquier.xyz> wrote:
> 
>> We have a couple of non-ASCII characters in the tests, but I suspect
>> that this one will not be digested correctly everywhere, even if
>> EUC_JP should be OK to use for the check.  How about writing an
>> arbitrary sequence of bytes into a temporary file that gets used for 
>> the COPY FROM instead?  See for example how we do that with
>> abs_builddir in copy.sql.
> 
> It makes sense. How about the attached patch?
> 
> 
> Thanks,
> -- 
> kou



pgsql-hackers by date:

Previous
From: Andrei Lepikhov
Date:
Subject: Re: Considering fractional paths in Append node
Next
From: Kirill Reshke
Date:
Subject: Re: Use streaming read API in pgstattuple.