Re: Why does pgindent's README say to download typedefs.list from the buildfarm? - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Date
Msg-id 20240515192952.GA1428991@nathanxps13
Whole thread Raw
In response to Re: Why does pgindent's README say to download typedefs.list from the buildfarm?  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
List pgsql-hackers
On Wed, May 15, 2024 at 12:06:03PM -0400, Robert Haas wrote:
> What jumps out at me when I read this patch is that it says that an
> incremental run should do steps 1-3 of a complete run, and then
> immediately backtracks and says not to do step 2, which seems a little
> strange.
> 
> I played around with this a bit and came up with the attached, which
> takes a slightly different approach. Feel free to use, ignore, etc.

This is much cleaner, thanks.  The only thing that stands out to me is that
the "once per release cycle" section should probably say to do an indent
run after downloading the typedef file.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: date_trunc function in interval version
Next
From: Robert Haas
Date:
Subject: Re: add function argument names to regex* functions.