Re: Fixup some StringInfo usages - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Fixup some StringInfo usages
Date
Msg-id 20240409013412.GA1431559@nathanxps13
Whole thread Raw
In response to [MASSMAIL]Fixup some StringInfo usages  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Tue, Apr 09, 2024 at 12:53:21PM +1200, David Rowley wrote:
> Similar to f736e188c, I've attached a patch that fixes up a few
> misusages of the StringInfo functions. These just swap one function
> call for another function that is more suited to the use case.
> 
> I've also attached the patch that I used to find these.  That's not
> intended for commit.
> 
> I feel like it's a good idea to fix these soon while they're new
> rather than wait N years and make backpatching bug fixes possibly
> harder.
> 
> I've attached a file with git blame commands to identify where all of
> these were introduced.  All are new to PG17.
> 
> Any objections?

Looks reasonable to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: [MASSMAIL]Fixup some StringInfo usages
Next
From: Amit Kapila
Date:
Subject: Re: pgsql: Fix the intermittent buildfarm failures in 040_standby_failover_