Re: Avoiding inadvertent debugging mode for pgbench - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Avoiding inadvertent debugging mode for pgbench
Date
Msg-id 202403111559.2ot5bbotwcgz@alvherre.pgsql
Whole thread Raw
In response to Re: Avoiding inadvertent debugging mode for pgbench  ("Euler Taveira" <euler@eulerto.com>)
Responses Re: Avoiding inadvertent debugging mode for pgbench
List pgsql-hackers
On 2024-Mar-01, Euler Taveira wrote:

> I don't like to break backward compatibility but in this case I suspect that it
> is ok. I don't recall the last time I saw a script that makes use of -d option.
> How often do you need a pgbench debug information?

I wondered what the difference actually is, so I checked.  In -i mode,
the only difference is that if the tables don't exist before hand, we
receive the NOTICE that it doesn't.  In normal mode, the -d switch emits
so much junk that I would believe if somebody told me that passing -d
distorted the benchmark results; and it's hard to believe that such
output is valuable for anything other than debugging pgbench itself.

All in all, I support the original patch.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"I love the Postgres community. It's all about doing things _properly_. :-)"
(David Garamond)



pgsql-hackers by date:

Previous
From: Jelte Fennema-Nio
Date:
Subject: Re: UUID v7
Next
From: Melanie Plageman
Date:
Subject: Re: Confine vacuum skip logic to lazy_scan_skip