Re: Rename setup_cancel_handler in pg_dump - Mailing list pgsql-hackers

From Yugo NAGATA
Subject Re: Rename setup_cancel_handler in pg_dump
Date
Msg-id 20240208100749.5fd43140906c8f973f294b9a@sraoss.co.jp
Whole thread Raw
In response to Re: Rename setup_cancel_handler in pg_dump  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Wed, 7 Feb 2024 22:59:48 +0100
Daniel Gustafsson <daniel@yesql.se> wrote:

> > On 1 Feb 2024, at 02:21, Yugo NAGATA <nagata@sraoss.co.jp> wrote:
> > On Tue, 30 Jan 2024 13:44:28 +0100
> > Daniel Gustafsson <daniel@yesql.se> wrote:
> 
> >> -setup_cancel_handler(void)
> >> +pg_dump_setup_cancel_handler(void)
> >> 
> >> We don't have any other functions prefixed with pg_dump_, based on the naming
> >> of the surrounding code in the file I wonder if set_cancel_handler is a more
> >> appropriate name?
> > 
> > Agreed. Here is a updated patch.
> 
> Sleeping on it I still think this is a good idea, and hearing no objections I
> went ahead with this.  Thanks for the patch!

Thank you!

Regards,
Yugo Nagata

> 
> --
> Daniel Gustafsson
> 


-- 
Yugo NAGATA <nagata@sraoss.co.jp>



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Should we remove -Wdeclaration-after-statement?
Next
From: Thomas Munro
Date:
Subject: Re: cfbot is failing all tests on FreeBSD/Meson builds