Re: cleanup patches for incremental backup - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: cleanup patches for incremental backup
Date
Msg-id 20240129211321.GA3676549@nathanxps13
Whole thread Raw
In response to Re: cleanup patches for incremental backup  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: cleanup patches for incremental backup
List pgsql-hackers
On Mon, Jan 29, 2024 at 03:18:50PM -0500, Robert Haas wrote:
> I'm wondering if what we need to do is run pg_walsummary on both
> summary files in that case. If we just pick one or the other, how do
> we know which one to pick?

Even if we do that, isn't it possible that none of the summaries will
include the change?  Presently, we get the latest summarized LSN, make a
change, and then wait for the next summary file with a greater LSN than
what we saw before the change.  But AFAICT there's no guarantee that means
the change has been summarized yet, although the chances of that happening
in a test are probably pretty small.

Could we get the LSN before and after making the change and then inspect
all summaries that include that LSN range?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Ants Aasma
Date:
Subject: Re: Change GUC hashtable to use simplehash?
Next
From: Melanie Plageman
Date:
Subject: Streaming read-ready sequential scan code