Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro
Date
Msg-id 20231114175917.GC2062604@nathanxps13
Whole thread Raw
In response to Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro
List pgsql-hackers
On Tue, Nov 14, 2023 at 12:10:41PM -0500, Tom Lane wrote:
> FWIW, I think it's fine to just nuke MemoryContextResetAndDeleteChildren.
> We ask extension authors to deal with much more significant API changes
> than that in every release, and versions where the updated code wouldn't
> work are long gone.  And, as you say, the existence of that separate from
> MemoryContextReset creates confusion, which has nonzero cost in itself.

That is my preference as well.  Alvaro, AFAICT you are the only vote
against removing it completely.  If you feel ѕtrongly about it, I don't
mind going the __attribute__((deprecated)) route, but otherwise, I'd
probably just remove it completely.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #18097: Immutable expression not allowed in generated at
Next
From: Nathan Bossart
Date:
Subject: Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro