Re: SET ROLE documentation improvement - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: SET ROLE documentation improvement
Date
Msg-id 20230915204711.GA2005906@nathanxps13
Whole thread Raw
In response to SET ROLE documentation improvement  (Yurii Rashkovskii <yrashk@gmail.com>)
Responses Re: SET ROLE documentation improvement
List pgsql-hackers
On Fri, Sep 15, 2023 at 11:26:16AM -0700, Yurii Rashkovskii wrote:
> I believe SET ROLE documentation makes a slightly incomplete statement
> about what happens when a superuser uses SET ROLE.
> 
> The documentation reading suggests that the superuser would lose all their
> privileges. However, they still retain the ability to use `SET ROLE` again.
> 
> The attached patch adds this bit to the documentation.

IMO this is arguably covered by the following note:

   The specified <replaceable class="parameter">role_name</replaceable>
   must be a role that the current session user is a member of.
   (If the session user is a superuser, any role can be selected.)

But I don't see a big issue with clarifying things further as you propose.

I think another issue is that the aforementioned note doesn't mention the
new SET option added in 3d14e17.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: semantics of "convenient to store" in FmgrInfo ?
Next
From: Nathan Bossart
Date:
Subject: Re: ALTER ROLE documentation improvement