Re: Add 'worker_type' to pg_stat_subscription - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Add 'worker_type' to pg_stat_subscription
Date
Msg-id 20230907222834.GA707471@nathanxps13
Whole thread Raw
In response to Re: Add 'worker_type' to pg_stat_subscription  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Add 'worker_type' to pg_stat_subscription
List pgsql-hackers
On Thu, Sep 07, 2023 at 12:36:29PM +1200, Peter Smith wrote:
> Modified as suggested. PSA v3.

Thanks.  I've attached v4 with a couple of small changes.  Notably, I've
moved the worker_type column to before the pid column, as it felt more
natural to me to keep the PID columns together.  I've also added an
elog(ERROR, ...) for WORKERTYPE_UNKNOWN, as that seems to be the standard
practice elsewhere.  That being said, are we absolutely confident that this
really cannot happen?  I haven't looked too closely, but if there is a
small race or something that could cause us to see a worker with this type,
perhaps it would be better to actually list it as "unknown".  Thoughts?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Eliminate redundant tuple visibility check in vacuum
Next
From: Bruce Momjian
Date:
Subject: Re: Document that server will start even if it's unable to open some TCP/IP ports