Re: [PATCH] Add function to_oct - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: [PATCH] Add function to_oct
Date
Msg-id 20230816142410.GA2651383@nathanxps13
Whole thread Raw
In response to Re: [PATCH] Add function to_oct  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: [PATCH] Add function to_oct
List pgsql-hackers
On Wed, Aug 16, 2023 at 10:35:27AM +0700, John Naylor wrote:
> ```
> *ptr = '\0';
> 
> do
> ```
> 
> to
> 
> ```
> *ptr = '\0';
> do
> ```

Oh, I misunderstood.  I thought you meant that there might be a whitespace
change on that line, not the surrounding ones.  This is fixed in v6.

> Now I'm struggling to understand why each and every instance has its own
> nominal buffer, passed down to the implementation. All we care about is the
> result -- is there some reason not to confine the buffer declaration to the
> general implementation?

We can do that if we use a static variable, which is what I've done in v6.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Önder Kalacı
Date:
Subject: Re: postgres_fdw: wrong results with self join + enable_nestloop off
Next
From: Peter Eisentraut
Date:
Subject: Re: Fix typo in src/interfaces/libpq/po/zh_CN.po